You are using StrToInt() with the strings that are stored in valuesa. So, why aren't you using a more appropriate container that holds integers instead of strings? TList<int> or std::vector<int> or similar.


System::String is an alias for System::AnsiString in CB2007 and earlier, and is an alias for System::UnicodeString in CB2009+. The RTL defines a System::Char alias for whatever character type System::String contains, as well as a _D() macro to map compile-time char/string literals to the same character type. In your case, System::UnicodeString contains System::WideChar elements, and System::WideChar is 16-bit on every platform ('wchar_t' on Windows, 'char16_t' on other platforms). As such, your 'tempi' variable needs to be declared as System::WideChar instead of 'char', or better as System::Char to match your use of System::String:

String temp;
Char tempi;  // to take the place of the i th value...

No, it doesn't work, because:

- you are assigning a 'char16_t' to a 'char'. At best, that will truncate character values > 0xFFFF without warning. At worse, it will fail to compile due to different character types being used.

- you are not taking into account that System::UnicodeString is 0-indexed or 1-indexed depending on platform. C++Builder compilers that use a 1-indexed System::UnicodeString define a precompiler conditional named _DELPHI_STRING_ONE_BASED, which you need to handle if you want to write cross-platform code.

Try something more like this instead:

String temp;
Char tempi;  // to take the place of the i th value...
 
for (int i = 0; i < temp.Length(); ++i)
{
    #ifdef _DELPHI_STRING_ONE_BASED
    tempi = temp[i+1];
    #else
    tempi = temp[i];
    #endif
    if (tempi == _D('A'))
        total += StrToInt(valuesa->Strings[i]);
}

Alternatively:

inline int Low(const System::String &)
{
    #ifdef _DELPHI_STRING_ONE_BASED
    return 1;
    #else
    return 0;
    #endif
}
 
inline int High(const System::String &S)
{
    #ifdef _DELPHI_STRING_ONE_BASED
    return S.Length();
    #else
    return S.Length()-1;
    #endif
}
 
String temp;
Char tempi;  // to take the place of the i th value...
 
int low = Low(temp);
int high = High(temp);
for (int i = low; i <= high; ++i)
{
    tempi = temp[i];
    if (tempi == _D('A'))
        total += StrToInt(valuesa->Strings[i-low]);
}

There is nothing in the code you have shown that behaves differently in 64-bit vs 32-bit. Whatever problem you are having is related to something else, most likely your misunderstanding of how System::String indexing works across different platforms.

--
Remy Lebeau (TeamB)